Skip to content

feat: add publishable flag to all templates#1621

Open
very-good-code-bot[bot] wants to merge 3 commits into
mainfrom
vgv-ai-bot/issue-1618
Open

feat: add publishable flag to all templates#1621
very-good-code-bot[bot] wants to merge 3 commits into
mainfrom
vgv-ai-bot/issue-1618

Conversation

@very-good-code-bot

@very-good-code-bot very-good-code-bot Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds support for the publishable flag to all templates (docs_site, flame_game, and flutter_app) by applying the Publishable mixin pattern consistently across create subcommands.

Changes

  • Added Publishable mixin to CreateDocsSite, CreateFlameGame, and CreateFlutterApp command classes
  • Updated usage documentation to show the new --publishable flag option
  • Updated test expectations to include publishable: false in template variables
  • Maintains consistency with the existing pattern used for other mixins like OrgName and MultiTemplates

Testing

Updated test cases in:

  • docs_site_test.dart
  • flame_game_test.dart
  • flutter_app_test.dart

All tests verify that the publishable flag is properly passed to templates with a default value of false.

Closes #1618

@very-good-code-bot @marcossevilla
feat: add publishable flag to all templates
65b7403 
Closes #1618

Co-authored-by: marcossevilla <marcossevilla@users.noreply.github.com>
@very-good-code-bot very-good-code-bot Bot requested a review from a team as a code owner June 19, 2026 10:13
@very-good-code-bot very-good-code-bot Bot mentioned this pull request Jun 19, 2026
Open
2 tasks
@marcossevilla

marcossevilla commented Jun 19, 2026

Copy link
Copy Markdown
Member

converting to draft until templates are bumped to new versions that support this change

@marcossevilla marcossevilla marked this pull request as draft June 19, 2026 10:16
@marcossevilla

marcossevilla commented Jun 22, 2026

Copy link
Copy Markdown
Member

@vgvbot run tool/generate_bundles.sh so new template bundles match the changes on this PR

@very-good-code-bot

very-good-code-bot Bot commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

On it, I'll address the review comments and push the changes.

  • Preparing environment
    • Cloning repository
    • Setting up dev environment
  • Reviewing feedback
  • Working on changes
  • Pushing updates

I've pushed changes to address the feedback.

very-good-code-bot Bot and others added 2 commits June 22, 2026 11:19
@very-good-code-bot @marcossevilla
fix: address review feedback on PR #1621
4618d76 
Co-authored-by: marcossevilla <marcossevilla@users.noreply.github.com>
@marcossevilla
Merge branch 'main' into vgv-ai-bot/issue-1618
d191c59
@marcossevilla marcossevilla marked this pull request as ready for review June 22, 2026 11:54
@very-good-code-bot

very-good-code-bot Bot commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

CI failed on this PR. I'm looking into it and will push a fix (attempt 1 of 3).

  • Preparing environment
    • Cloning repository
    • Setting up dev environment
  • Inspecting CI failures
  • Working on fix
  • Pushing fix

Sorry, I ran into an error while processing your request. Please check the logs for details.

🔍 View this task run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: add publishable flag to all templates

1 participant

@marcossevilla